Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 8.4 (LTS) variant #1046

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Add 8.4 (LTS) variant #1046

merged 4 commits into from
Apr 30, 2024

Conversation

jnoordsij
Copy link
Contributor

@jnoordsij jnoordsij commented Apr 30, 2024

This PR adds 8.4, the new LTS release, as variant. See also https://dev.mysql.com/doc/relnotes/mysql/8.4/en/news-8-4-0.html.

To do so, the update.sh script has been updated to use "https://repo.mysql.com/yum/mysql-tools-$version-community/el/$oracleVersion" as new default url for tools, hoping this is the new convention (didn't check for any official statements); see also https://repo.mysql.com/yum/.

No Debian variant was added per #867 (comment).

Moreover, I've taken the liberty to add an lts alias, which seems appropriate to me. If not, feel free to (ask me to) remove that.

Finally, when going through the sources I noticed that Oracle Linux 9 has been released a while back. I could not find any support policies regarding OS versions for this image so quickly, but if variants are preferably kept on the same OS for stability, considering to use v9 for this variant is probably appropriate. Otherwise, updating could be left as a separate (unrelated) follow-up PR.

@yosifkit
Copy link
Member

🤔 https://dev.mysql.com/blog-archive/introducing-mysql-innovation-and-long-term-support-lts-versions/
The next innovation release will be the first of the 9.x series and they are roughly quarterly, but not at the same time as an LTS. So, I think we should figure out how to disable innovation until we have 9.x (or maybe the innovation tags should point at the LTS?)

@tianon
Copy link
Member

tianon commented Apr 30, 2024

Hmm, yeah -- I think we probably shouldn't tag this new release as innovation, since it isn't technically in the innovation "track" (the latest "innovation" release is still 8.3).

I think at most we should update to avoid building innovation while any explicit release has a higher version number so that we don't have to revisit this once innovation gets 9.x -- we've got some code for that elsewhere that I could adapt here. 👍

As usual @jnoordsij, excellent and well-thought-out contribution. 😄 Thank you! ❤️

@tianon
Copy link
Member

tianon commented Apr 30, 2024

Oh sorry, I also think the lts alias is probably OK? It's clearly a word upstream is using to describe this. 👍

@tianon
Copy link
Member

tianon commented Apr 30, 2024

Oh and further, regarding upgrades like OL9, if upstream supports it (and recommends using it), we're generally in favor of doing it. Last time I looked, they did not have the Docker-specific package builds we're using available for it, but maybe that's changed, or is different for the new 8.4?

We're in a temporary state where we have 8.4 as the freshly minted LTS and innovation still points to 8.3 (which is now "EOL") until 9.x -- this implementation ensures we bring innovation back automatically when it gets 9.x.

See also https://dev.mysql.com/blog-archive/introducing-mysql-innovation-and-long-term-support-lts-versions/ especially the final graphic.
@yosifkit yosifkit merged commit d972901 into docker-library:master Apr 30, 2024
5 checks passed
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Apr 30, 2024
Changes:

- docker-library/mysql@d972901: Merge pull request docker-library/mysql#1046 from jnoordsij/add-8.4
- docker-library/mysql@784047f: Skip "innovation" when any other release is newer
- docker-library/mysql@53973fa: Add lts alias
- docker-library/mysql@c054224: Add 8.4 variant (new LTS)
- docker-library/mysql@e3c2853: Update toolsRepo detection in versions.sh
- docker-library/mysql@2319f17: Update innovation to mysql-shell 8.4.0-1.el8
- docker-library/mysql@5fe2b70: Update 8.0 to 8.0.37, debian 8.0.37-1debian12, mysql-shell 8.0.37-1.el8, oracle 8.0.37-1.el8
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Apr 30, 2024
Changes:

- docker-library/mysql@9f0f4a1: Add plain 8 aliases
- docker-library/mysql@d972901: Merge pull request docker-library/mysql#1046 from jnoordsij/add-8.4
- docker-library/mysql@784047f: Skip "innovation" when any other release is newer
- docker-library/mysql@53973fa: Add lts alias
- docker-library/mysql@c054224: Add 8.4 variant (new LTS)
- docker-library/mysql@e3c2853: Update toolsRepo detection in versions.sh
- docker-library/mysql@2319f17: Update innovation to mysql-shell 8.4.0-1.el8
- docker-library/mysql@5fe2b70: Update 8.0 to 8.0.37, debian 8.0.37-1debian12, mysql-shell 8.0.37-1.el8, oracle 8.0.37-1.el8
@jnoordsij jnoordsij deleted the add-8.4 branch May 1, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants