Revert "Bump rust version" #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some corrections: This is alpine-only and the PR I linked seems to not be that relevant. I did a build with nightly and the build error still occurs. The PR in LLVM (llvm/llvm-project#93890) has not been backported as far as I can tell. |
|
I'll try this again next year or so, after 2-3 rust releases. Per the ruby issue, should be a good chance it will work correctly everywhere then. Looks like the missing backport was the culprit after all. |
yosifkit
approved these changes
Nov 4, 2024
|
Thanks! |
|
This should be a revert of e76791f, not the merge commit, right? (doing it that way makes the changes/history easier to track) |
This reverts commit e76791f. I chose an inopportune time to do this. There is an upstream issue where builds on alpine arm64/v8 fail: https://bugs.ruby-lang.org/issues/20506 Example failure: https://doi-janky.infosiftr.net/job/wip/job/new/job/build-arm64v8/45573/console I believe rust-lang/rust#131221 will fix this but it is only slated for Rust 1.83
Earlopain
force-pushed
the
revert-rust-bump
branch
from
ea1a30b
to
f268d39
Compare
Earlopain
changed the title
Earlopain
changed the title
|
I don't think there is much difference execpt for the generated commit message? I switched it over, not very familiar with git reverting. |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Nov 5, 2024
Changes: - docker-library/ruby@6bb29d9: Merge pull request docker-library/ruby#479 from Earlopain/revert-rust-bump - docker-library/ruby@f268d39: Revert "Bump rust version"
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Nov 5, 2024
Changes: - docker-library/ruby@b511945: Update 3.3 to 3.3.6 - docker-library/ruby@6bb29d9: Merge pull request docker-library/ruby#479 from Earlopain/revert-rust-bump - docker-library/ruby@f268d39: Revert "Bump rust version"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 89946d9, reversing changes made to 7cb059d.
I chose an inopportune time to do this.
There is an upstream issue where builds on arm64/v8 fail: https://bugs.ruby-lang.org/issues/20506
Example failure: https://doi-janky.infosiftr.net/job/wip/job/new/job/build-arm64v8/45573/console
I believe rust-lang/rust#131221 will fix this but it is only slated for Rust 1.83