Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support checkpoint restore #3094

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Support checkpoint restore #3094

wants to merge 5 commits into from
+417 −7

Conversation

sdimovv
Copy link

@sdimovv sdimovv commented Feb 3, 2023

Added support for the experimental checkpoint-restore docker API.

Couple of notes:

  1. I have intentionally omitted adding a dedicated method for checking if the experimental features are enabled in the docker daemon, since this can be deduced from the version information (self.client.version())
  2. I have added docstrings to all new classes and methods, not sure if there is a need to manually add any docs? Can fix if needed.

@sdimovv
Copy link
Author

sdimovv commented Feb 28, 2023

Hi @aiordache and @ulyssessouza,

does this need anything else to get merged? I'll be happy to resolve any issues you might have.

@lumost
Copy link

lumost commented Aug 3, 2023 •
edited
Loading

Thanks for this! I'll be using this CR :) Curious if this is also related to https://pypi.org/project/docker-with-criu/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiordache aiordache Awaiting requested review from aiordache

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sdimovv @lumost