Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keyerror when creating new config(#3110) #3200

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

Khushiyant
Copy link
Contributor

fix #3110

@Khushiyant Khushiyant force-pushed the keyerror-config branch 2 times, most recently from 447d861 to a85cb94 Compare December 21, 2023 06:04
Signed-off-by: Khushiyant <khushiyant2002@gmail.com>
@Khushiyant
Copy link
Contributor Author

@milas PTAL

Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - behavior of the API is weird as well as the docker-py handling, but this is identical to how it's handled for secrets, so good enough

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas milas enabled auto-merge (squash) January 3, 2024 18:39
@milas milas added the kind/bug label Jan 3, 2024
@milas milas self-assigned this Jan 3, 2024
@milas milas merged commit b8a6987 into docker:main Jan 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create config object
2 participants