Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize build to use hatchling and hatch-vcs #3207

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

akx
Copy link
Contributor

@akx akx commented Dec 21, 2023

This PR switches the packaging for docker-py from the old and busted setup.cfg + setup.py stuff to PEP517 Hatch's hatchling and the hatch-vcs plugin to provide what setuptools_scm did.

Aside from superficial changes in metadata structure (and file times being static for more reproducible builds), the resulting wheels are the same (and of course the _version file is different because there's two extra commits here...):

comp1

There's also an added GitHub Actions workflow that builds the wheel even when not publishing, so you can look at the results for any given PR.

Note

This PR includes #3205 – it drops packaging out of the requirements.

@akx akx force-pushed the modernize-build branch 2 times, most recently from 802838f to 854dd83 Compare December 21, 2023 08:52
@milas milas self-assigned this Jan 3, 2024
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A HUGE thanks from me, this is long overdue and looks great.

@milas milas merged commit 0fd79c8 into docker:main Mar 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants