Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration::setMetadataCacheImpl is deprecated since mongodb-odm 2.2 #279

Closed
rieschl opened this issue Sep 1, 2023 · 1 comment
Closed
Labels
Enhancement New feature or request
Milestone

Comments

@rieschl
Copy link
Contributor

rieschl commented Sep 1, 2023

Hey!

The method \Doctrine\ODM\MongoDB\Configuration::setMetadataCacheImpl was deprecated in monbodb-odm 2.2.
This package calls it in the ConfigurationFactory, though.

Are there plans to upgrade this package to avoid the deprecation warning? Should I have a look at it?
At first glance, the most simple fix would be wrapping the current cache implementation (CacheAdapter::wrap($cacheImpl)) and call setMetadataCache() instead of setMetadataCacheImpl(). Maybe checking if the cache returned by $container->get($configurationOptions->getMetadataCache()) is already a PSR-6 cache, to be forward compatible.

Thanks!

@driehle driehle added the Enhancement New feature or request label Oct 15, 2023
@driehle driehle added this to the 5.0.1 milestone Oct 15, 2023
@driehle
Copy link
Member

driehle commented Oct 15, 2023

Closed by #280

@driehle driehle closed this as completed Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants