Avoid using deprecated methods #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@driehle any feedback? Thanks 🙂 |
|
Try pulling As I am writing this, I remember that there was some issue with the new method signatures of Doctrine's core classes. Could it be that |
driehle
reviewed
Oct 2, 2023
MongoDB ODM 2.2 deprecated `Doctrine\ODM\MongoDB\Configuration::getMetadataCacheImpl()` and `Doctrine\ODM\MongoDB\Configuration::setMetadataCacheImpl()` in favor of Configuration::getMetadataCache and `Configuration::setMetadataCache()`, respectively which use a PSR-6 compliant cache instead of doctrine/cache. I refrained from allowing to pass a PSR-6 `CacheItemPoolInterface` directly for now, because it's currently unlikely that a cache pulled from `doctrine.cache.[name]` service key will return a PSR-6 cache. Such a change would probably also require changes in doctrine-module and doctrine-orm-module. If you want me to implement that forward compatibility layer right away it's also ok for me. Signed-off-by: Thomas Rieschl <thomas@trinet.at>
Signed-off-by: Thomas Rieschl <thomas@trinet.at>
rieschl
force-pushed
the
qa/mongodb-deprecation
branch
from
87f3fc4
to
aeadd0e
Compare
driehle
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoDB ODM 2.2 deprecated
Doctrine\ODM\MongoDB\Configuration::getMetadataCacheImpl()andDoctrine\ODM\MongoDB\Configuration::setMetadataCacheImpl()in favor ofConfiguration::getMetadataCacheandConfiguration::setMetadataCache(), respectively, which use a PSR-6 compliant cache instead of doctrine/cache.I refrained from allowing to pass a PSR-6
CacheItemPoolInterfacedirectly for now, because it's currently unlikely that a cache pulled fromdoctrine.cache.[name]service key will return a PSR-6 cache. Such a change would probably also require changes in doctrine-module and doctrine-orm-module.But if you want me to implement that forward compatibility layer right away it's also ok for me.
fixes #279