Skip to content

Commit

Permalink
#751 adjusting test case: foo(?string $bar = null, $baz) is equival…
Browse files Browse the repository at this point in the history
…ent to `foo(string $bar = null, $baz)`, so no need to be too strict
  • Loading branch information
Ocramius committed Dec 3, 2016
1 parent 84c02e4 commit 6fe29f8
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions tests/Doctrine/Tests/Common/Proxy/ProxyGeneratorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,9 @@ public function testClassWithPhp71NullableOptionalNonLastParameterOnProxiedMetho
}

$this->assertContains(
'public function midSignatureNullableParameter(?string $param = NULL, $secondParam)',
file_get_contents(__DIR__ . '/generated/__CG__DoctrineTestsCommonProxyPhp71NullableDefaultedNonOptionalHintClass.php')
'public function midSignatureNullableParameter(string $param = NULL, $secondParam)',
file_get_contents(__DIR__ . '/generated/__CG__DoctrineTestsCommonProxyPhp71NullableDefaultedNonOptionalHintClass.php'),
'Signature allows nullable type, although explicit "?" marker isn\'t used in the proxy'
);

$this->assertContains(
Expand Down

0 comments on commit 6fe29f8

Please sign in to comment.