Use exception in OCI8 driver, instead of relying on assert

[segrax]

Fixes a bug where disabled asserts in production left oci_parse() errors unchecked. Now uses explicit checks and exceptions

Fixes #6595

Q	A
Type	bug
Fixed issues	#6595

Summary

Fixes a bug where disabled asserts in production left oci_parse()
errors unchecked. Now uses explicit checks and exceptions

[derrabus]

Thank you. Can we cover this change with a test?

[segrax]

Thank you. Can we cover this change with a test?

yeah, test has just been added

[segrax]

@derrabus should be all good, the last failing test seems to be unrelated (and has happened a couple of times now)

Failures
 - sqlite (exited 1) - sqlite not installed. An error occurred during installation:
 The remote server returned an error: (503) Server Unavailable. Service Unavailable: Back-end server is at capacity
Sorry, we tried running command for 3 times and all attempts were unsuccessful!

Get-ChildItem : Cannot find path 'C:\tools\php' because it does not exist.
At line:6 char:3
+   Get-ChildItem -Path c:\tools\php
+   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (C:\tools\php:String) [Get-ChildItem], ItemNotFoundException
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.GetChildItemCommand
 
cd : Cannot find path 'C:\tools\php' because it does not exist