Fix dropping the PK on a PostgreSQL table with quoted name #6599
+20
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was discovered during the work on #6589. If a table name passed to
PostgreSQLPlatform#getDropIndexSQL()
is quoted, it will generate invalid SQL (see the test).The fix is a quite ugly as the code parses the provided string. This is inherent to the current platform and schema management API design where
string $name
can contain virtually anything (quoted or unquoted, qualified or unqualified name) and is meant to be used to in concatenation with other SQL fragments, not parsed. We will address this design issue later by making object names value objects.