Merge pull request #381 from dodona-edu/fix/javascript-errors

Enable strict mode in JavaScript

tested/languages/javascript/config.py

@@ -90,6 +90,7 @@ def map_type_restrictions(self) -> Optional[Set[ExpressionTypes]]:
  return {BasicStringTypes.TEXT}
 
  def set_type_restrictions(self) -> Optional[Set[ExpressionTypes]]:
+ # noinspection PyTypeChecker
  return {
  "integer",
  "real",
@@ -131,6 +132,13 @@ def modify_solution(self, solution: Path):
  except TimeoutError:
  pass
 
+ # Add strict mode to the script.
+ with open(solution, "r") as file:
+ non_strict = file.read()
+ with open(solution, "w") as file:
+ file.write('"use strict";\n\n' + non_strict)
+ self.config.dodona.source_offset += 2
+
  def linter(self, remaining: float) -> Tuple[List[Message], List[AnnotateCode]]:
  # Import locally to prevent errors.
  from tested.languages.javascript import linter

tested/languages/kotlin/config.py

@@ -177,7 +177,7 @@ def linter(self, remaining: float) -> Tuple[List[Message], List[AnnotateCode]]:
  return linter.run_ktlint(self.config.dodona, remaining)
 
  def find_main_file(
- self, files: List[str], name: str, precompilation_messages: List[str]
+ self, files: List[Path], name: str, precompilation_messages: List[str]
  ) -> Tuple[Optional[str], List[Message], Status, List[AnnotateCode]]:
  logger.debug("Finding %s in %s", name, files)
  main, msgs, status, ants = Language.find_main_file(
@@ -188,7 +188,7 @@ def find_main_file(
  else:
  return Language.find_main_file(self, files, name, precompilation_messages)
 
- def filter_dependencies(self, files: List[Path], context_name: str) -> List[str]:
+ def filter_dependencies(self, files: List[Path], context_name: str) -> List[Path]:
  def filter_function(file: Path) -> bool:
  # We don't want files for contexts that are not the one we use.
  prefix = conventionalize_namespace(self, EXECUTION_PREFIX)

tested/languages/python/config.py

@@ -90,6 +90,7 @@ def datatype_support(self) -> Mapping[AllTypes, TypeSupport]:
  }
 
  def map_type_restrictions(self) -> Optional[Set[ExpressionTypes]]:
+ # noinspection PyTypeChecker
  return {
  "integer",
  "real",