Use here-doc for stdin if both stdin and arguments are used #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for the here-doc to display correctly.
|
Colouring wasn't reliable either in the current representation (text highlighted as if it were a shell command), so that's no reason not to make the change. Indeed looks like an improvement to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we just add the stdin below the command that is executed, which is not clear at all. We now use here-doc to display stdin in that case.
If only stdin is used, nothing changes: only stdin is shown.
It looks like this:
The colouring is sometimes a bit wonky, both Rouge and Pygments are not that good at highlighting here-docs.
Fixes #484.