Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add newlines to empty strings #501

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

niknetniko
Copy link
Member

When updating the documentation, it occurred to me that we currently also append newlines to empty strings for stdout/stderr. This is probably not what we want (since an empty stdout/stderr is perfectly fine), and also not how POSIX defines a file (zero or more lines).

@pdawyndt
Copy link
Contributor

I actually ran into this issue for one of the JavaScript exercises: after changing the newline handling, there was a single test suite that had expected stderr specified as the empty string. I had to remove the specification of stderr (which was actually not needed) for exactly the reason that was mentioned here. The fix would have indeed resolved the issue as well.

@niknetniko niknetniko merged commit 106446b into master Feb 21, 2024
7 checks passed
@niknetniko niknetniko deleted the enhance/newlines-again branch February 21, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants