Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JavaScript integration tests #512

Merged
merged 9 commits into from
May 30, 2024
Merged

Add JavaScript integration tests #512

merged 9 commits into from
May 30, 2024

Conversation

niknetniko
Copy link
Member

@niknetniko niknetniko commented May 28, 2024

Inspired by the tests for Pythia, this adds "integration tests". Since we now have a set of JavaScript exercises, this will test the sample solution of all exercises (except blacklisted ones), and check that they are correct.

To prevent false failed tests, the repo is pinned to a known commit, meaning it will need to be updated manually every once in a while.

In the future, we could add other repositories if we want to ensure compatibility with existing exercises.

TODO:

  • Add deploy key to js repo
  • Run the test every time
  • Make the test optional for merging (maybe we want this in the future?)
  • Make tests stricter: at least count number of tests (checking the actual feedback is probably overkill).
  • Do not use the Dodona docker image for this, use the dependencies from this repo for it.
    • Or not, maybe using it is good?

Base automatically changed from experiment/nix to master May 29, 2024 14:16
@niknetniko niknetniko marked this pull request as ready for review May 29, 2024 14:36
@niknetniko niknetniko force-pushed the tests/js-integration branch 8 times, most recently from 08204bf to 29aac96 Compare May 29, 2024 19:41
@niknetniko niknetniko merged commit d842e31 into master May 30, 2024
8 checks passed
@niknetniko niknetniko deleted the tests/js-integration branch May 30, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant