net: added http server #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config: updated libevent libs spv: added http server spvnode: added http server wallet: moved utxos init to load test: updated spv_tests for http server
xanimo
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
This is a great first step towards adding some way to interact with the spvnode while it's running. Next steps in my opinion would be authentication, encryption/decryption, buttoning up csp, cors, hsts, logging, etc. but for example/development purposes this works fine.
Tested on x86_64-pc-linux-gnu ubuntu jammy. ACK.
michilumin
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added HTTP server functionality to SPV node, enabling RESTful access to node and wallet data through endpoints like
/getBalanceand/getChaintip, along with a new command-line option-ufor setting the server's IP and port.