[WIP] Optimized JSSEngine #591
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
optimized-jssengine
branch
2 times, most recently
from
1386601
to
dce02ea
Compare
cipherboy
force-pushed
the
optimized-jssengine
branch
from
dce02ea
to
cc28403
Compare
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
j_bytebuffer wraps the byte array underlying a ByteBuffer; this allows us to call PR.Read and have it read directly from the underlying ByteBuffer, rather than copying it into a temporary buffer before the Read call. This, in turn, means we're making fewer JNI round-trips: we only need to pass the array to the underlying j_bytebuffer, call PR_Read, and it'll handle getting all the data it can in a single pass, resulting in fewer loops inside JSSEngine. Signed-off-by: Alexander Scheel <ascheel@redhat.com>
Like BufferPRFD, ByteBufferPRFD implements a NSPR PRFileDesc layer. Instead of maintaining a set of buffers up front, ByteBufferPRFD holds a reference to a pair of j_bytebuffers, each of which in turn wraps a single ByteBuffer instance. This allows for direct reading/writing of the buffers passed to a SSLEngine's wrap/unwrap call without first copying to an intermediate buffer. Signed-off-by: Alexander Scheel <ascheel@redhat.com>
These wrap the j_bytebuffer implementation from a previous call and expose them via the Java layer for use by other callers. Signed-off-by: Alexander Scheel <ascheel@redhat.com>
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
optimized-jssengine
branch
from
cc28403
to
d2b3605
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whee!
This adds an optimized JSSEngine! More description Monday. :)