Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check verify all clones #4523

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

fmarco76
Copy link
Member

@fmarco76 fmarco76 commented Aug 2, 2023

pki-healthcheck stop its activity in case a clone is not working and report the error. If multiple clones are configured the check should go ahead to verify the other clones.

With this fix all clones are verified during the health check.

`pki-healthcheck` stop its activity in case a clone is not working and
report the error. If multiple clones are configured the check should go
ahead to verify the other clones.

With this fix all clones are verified during the health check.
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This is a separate discussion, feel free to merge the PR regardless. I'm actually not sure why we need to check the clones in the healthcheck tool. Usually a healthcheck tool is used by a monitoring system to see whether a service on a particular machine is running properly, and if not the monitoring system will restart that machine or spawn a new one. If each machine also checks other machines (i.e. clones), that means there is a lot of redundant checks which could slow down the overall performance.

@fmarco76
Copy link
Member Author

fmarco76 commented Aug 3, 2023

I'm actually not sure why we need to check the clones in the healthcheck tool. Usually a healthcheck tool is used by a monitoring system to see whether a service on a particular machine is running properly, and if not the monitoring system will restart that machine or spawn a new one

I am not sure how it is used but I can imagine the pki-healthcheck can be easily integrated in the monitoring system to get status information of the service while other checks controls the involved machine are just up and running.

@fmarco76
Copy link
Member Author

fmarco76 commented Aug 3, 2023

@edewata Thanks!

@fmarco76 fmarco76 merged commit c6978c0 into dogtagpki:master Aug 3, 2023
@ckelleyRH
Copy link
Contributor

Part of the problem is that older systems can run checks against newer systems, which can have breaking API changes that cause the checks to fail. We have already had bug reports of this nature. We need to discuss with the IPA team, but we should either not support this or, if we do, it needs to be made more resilient to possible limitations of external systems.

@fmarco76 fmarco76 deleted the HealthCheckLoop branch August 8, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants