Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for subordinate CA clone #4546

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Aug 16, 2023

A new test has been added to install a subordinate CA with external cert then clone it into another instance. The test will also compare the CS.cfg, the users, and the certs in these instances to ensure that they are (mostly) identical.

The .gitignore has been updated to ignore files generated by other branches.

@edewata edewata requested a review from ladycfu August 16, 2023 17:40

- name: Issue primary sub-CA signing cert
run: |
# https://github.com/dogtagpki/pki/wiki/Creating-Self-Signed-CA-Signing-Certificate-with-PKI-NSS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the right link? It looks to be the same link as the self-sign ca above, which only shows how to do self-sign, not with --issuer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ladycfu ladycfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no expert on yml, but other than the comment referring to an url that doesn't seem to match the description, the logic looks good. I'm approving.
You an decide whether you wish to change that comment or not.

A new test has been added to install a subordinate CA with
external cert then clone it into another instance. The test
will also compare the CS.cfg, the users, and the certs in
these instances to ensure that they are (mostly) identical.

The .gitignore has been updated to ignore files generated
by other branches.
@edewata
Copy link
Contributor Author

edewata commented Aug 16, 2023

@ladycfu Thanks! I've fixed the link. I'll merge once the CI is complete.

@edewata edewata merged commit bef9102 into dogtagpki:v10.13 Aug 16, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants