Add Buildrequires for fontawesome

[ckelleyRH]

This resolves a disparity in installed files between Maven and CMake now that fontawesome is not bundled in the CMake build anymore.

This happens because font-awesome is not available at build time so there is no file to link to for the comparison.

[ckelleyRH]

The right file should now be installed to link to, but I still need to create the link for the CMake build somehow.

[ckelleyRH]

Hi @edewata, I think I am partway fixed. I'm not sure what the best way to create the symlink is in cmake as it is conditional on a particular version of Fedora and we don't have access to the nice spec file macros. Any ideas?

The alternative, as this all works at run-time and is failing in a test only, we could simply exclude the fonts using sed like we do for cmake/Maven specific things?

[edewata]

I think we can use find_file() to find the actual file in all possible locations, then create the link in CMake. I don't think we should exclude the font from the test since this might affect the installation for non-RPM-based platforms, so the test is actually catching a real build issue. Sorry I didn't check Azure before merging that commit.

[ckelleyRH]

@edewata - I'm a bit confused by this now, as ln is claiming that the file exists already, but I don't see how that can be possible as the whole point of this change is to fix that it doesn't exist. Can you take a look please?

[edewata]

Looks like the link to fontawesome-webfont.woff was created and installed successfully by CMake:
https://github.com/dogtagpki/pki/actions/runs/6260272159/job/16998012354#step:7:14612
but the RPM spec is still trying to create the link again in the same location:
https://github.com/dogtagpki/pki/actions/runs/6260272159/job/16998012354#step:7:14872
I think you just need to remove these lines:

pki/pki.spec

Lines 960 to 969 in c8fd8aa

	%if %{with theme}
	# create links to FontAwesome fonts
	%if 0%{?fedora} > 38
	ln -s ../../../fonts/fontawesome4/fontawesome-webfont.woff \
	%{buildroot}%{_datadir}/pki/common-ui/fonts/fontawesome-webfont.woff
	%else
	ln -s ../../../fonts/fontawesome/fontawesome-webfont.woff \
	%{buildroot}%{_datadir}/pki/common-ui/fonts/fontawesome-webfont.woff
	%endif
	%endif

so now the link will be created by CMake (which will work on all platforms) instead of by rpmbuild (which will only work on certain platforms).

[ckelleyRH]

so now the link will be created by CMake (which will work on all platforms) instead of by rpmbuild (which will only work on certain platforms).

Ah, yes I've misunderstood what was happening, thanks for the clarification! I have fixed the merge conflict and I think now the CI will pass.

[ckelleyRH]

@edewata - yep, it works, thanks again!

[edewata]

Thanks for the update! There's a test failure, but feel free to fix and merge.

[edewata]

Looks like rpminspect failed because the link is incorrect. The final location for the link is /usr/share/pki/common-ui/fonts so it only needs 5 ..'s.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
2.1% Duplication

[ckelleyRH]

Thanks @edewata !