Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InfoServlet with APIv2 #4596

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Add InfoServlet with APIv2 #4596

merged 3 commits into from
Nov 9, 2023

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Oct 31, 2023

This PR provides a lightweight framework for a APIv2 and an example showing that the same service can be provided via both APIv1 and APIv2 without duplicating a lot of code.

The PKIEngine has been added to store the main code of PKI web application. PKIWebListener has been added to initialize the PKIEngine when the web application is started. PKIServlet has been added as the base class for servlets that use PKIEngine.

The code that constructs the Info object in InfoService has been moved into PKIEngine such that it can be reused.

The InfoServlet has been added as a lightweight alternative to InfoService without dependency on RESTEasy.

All clients have been modified to call the InfoServlet instead.

The PKIEngine has been added to store the main code of PKI web
application. PKIWebListener has been added to initialize the
PKIEngine when the web application is started. PKIServlet has
been added as the base class for servlets that use PKIEngine.
The code that constructs the Info object in InfoService has
been moved into PKIEngine such that it can be reused.
The InfoServlet has been added as a lightweight alternative to
InfoService without dependency on RESTEasy.

All clients have been modified to call the InfoServlet instead.
@edewata edewata requested a review from fmarco76 October 31, 2023 19:34
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@edewata edewata changed the title Add InfoServlet Add InfoServlet with APIv2 Nov 2, 2023
Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented Nov 9, 2023

@fmarco76 Thanks!

@edewata edewata merged commit 3058989 into dogtagpki:master Nov 9, 2023
130 of 131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants