Implement CA Info REST v2 #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edewata
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
The changes look good, but should we change the client too?
I think the old API is used in this test: https://github.com/dogtagpki/pki/blob/master/.github/workflows/kra-oaep-test.yml#L112
And also in this client code:
https://github.com/dogtagpki/pki/blob/master/base/common/src/main/java/org/dogtagpki/common/CAInfoClient.java#L30
It needs to be changed to:
super(client, subsystem, "v2", "info");
Maybe we need to change the client constructors so it's easier to identify in the future.
Feel free to update/merge. Thanks!
fmarco76
force-pushed
the
CAInfoAPIv2
branch
from
52a957b
to
71b0928
Compare
The code of CAInfoService.java has moved to CAEngine and used for the current API and the new v2 API. Introduced a base servlet for all CA APIs and the servlet for the Info end-point. No code changes performed.
fmarco76
force-pushed
the
CAInfoAPIv2
branch
from
71b0928
to
7ce19f8
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
I have updated the client and the CI workflow to use the new end-point. |
|
@edewata Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code of CAInfoService.java has moved to CAEngine and used for the current API and the new v2 API.
Introduced a base servlet for all CA APIs and the servlet for the Info end-point.
No code changes performed.