Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting the test-ca-certs.sh #4877

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

fmarco76
Copy link
Member

The file is currently used for JSS tests
@fmarco76 fmarco76 requested a review from edewata October 14, 2024 18:13
Copy link

sonarcloud bot commented Oct 14, 2024

Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This test is probably going to fail when we switch to APIv2 since the CLI won't return the total entries found anymore. We should find a better way to test, but for now feel free to merge. Thanks!

@fmarco76
Copy link
Member Author

This test is probably going to fail when we switch to APIv2 since the CLI won't return the total entries found anymore. We should find a better way to test, but for now feel free to merge. Thanks!

Yes, after the switch some tests could requires changes. I have identified a couple of tests to be modified in the switch PR but improving the APIs other will requires changes.

@fmarco76
Copy link
Member Author

@edewata Thanks!

@fmarco76 fmarco76 merged commit 41465e2 into dogtagpki:master Oct 15, 2024
148 of 166 checks passed
@fmarco76 fmarco76 deleted the fixJssMissignTestCaCert branch October 24, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants