Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump starknet to 0.12.0 #2454

Merged
merged 7 commits into from
Sep 20, 2024
Merged

Bump starknet to 0.12.0 #2454

merged 7 commits into from
Sep 20, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Sep 19, 2024

resolves #2452

  • bump starknet to 0.12.0
  • bump starknet-types-core to 0.1.6

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Introduced a new asynchronous method for handling multiple JSON-RPC requests, enhancing batch request capabilities.
  • Bug Fixes

    • Updated various dependencies to improve stability and compatibility, including major upgrades for starknet and alloy-* libraries.

These changes focus on enhancing the application's performance and reliability for end-users.

@tcoratger
Copy link
Contributor

@kariy

@kariy
Copy link
Member Author

kariy commented Sep 19, 2024

@kariy

yup,

  • I'm trying to obtain a new release of starknet-types-core so that we can remove all patches

yes pls. would very much appreciate that

@kariy kariy marked this pull request as ready for review September 19, 2024 19:09
Copy link

coderabbitai bot commented Sep 19, 2024

Walkthrough

Ohayo, sensei! This pull request primarily focuses on updates to the Cargo.toml file, enhancing dependency management by specifying stable versions for several libraries. Notable changes include upgrading the cainome, alloy-*, starknet, and slot dependencies. Additionally, a new asynchronous method send_requests has been introduced in the MockJsonRpcTransport implementation, although its functionality is not yet defined.

Changes

File Change Summary
Cargo.toml Updated dependencies: cainome, alloy-primitives, alloy-sol-types, various alloy-* libraries, starknet, and starknet-types-core.
crates/dojo-test-utils/src/rpc.rs Added an asynchronous method send_requests to MockJsonRpcTransport, currently unimplemented.

Assessment against linked issues

Objective Addressed Explanation
Remove patches from Cargo.toml (#2452)
Bump starknet dependency (#2452)
Remove custom patches to ease integration (#2452) Custom patches are still present.

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e2ffbf8 and 72767b2.

Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
Files selected for processing (1)
  • Cargo.toml (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • Cargo.toml

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kariy
Copy link
Member Author

kariy commented Sep 19, 2024

@tcoratger the pr is pretty much ready except for the starnet-types-core release. will defer merging until the release is out.

@tcoratger
Copy link
Contributor

@tcoratger the pr is pretty much ready except for the starnet-types-core release. will defer merging until the release is out.

@kariy sure will post a message here once I've a release

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.30%. Comparing base (82a23a5) to head (72767b2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/dojo-test-utils/src/rpc.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2454      +/-   ##
==========================================
+ Coverage   68.29%   68.30%   +0.01%     
==========================================
  Files         365      365              
  Lines       48034    48037       +3     
==========================================
+ Hits        32805    32812       +7     
+ Misses      15229    15225       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcoratger
Copy link
Contributor

@kariy should be done here starknet-io/types-rs#95

@tcoratger
Copy link
Contributor

@kariy Cool thanks a lot for this, is it possible to merge asap because this is blocking for us at Kakarot :) ?

@kariy
Copy link
Member Author

kariy commented Sep 20, 2024

@kariy Cool thanks a lot for this, is it possible to merge asap because this is blocking for us at Kakarot :) ?

Ahh sorry. The Windows build is still breaking but didn't have enough time to debug it today. Will get it merged first thing tomorrow!

@kariy kariy merged commit 7ff6593 into main Sep 20, 2024
14 of 15 checks passed
@kariy kariy deleted the bump-starknet branch September 20, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove patches from Cargo.toml
2 participants