-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove redundant words in comment #2752
Conversation
Signed-off-by: rusttech <gopher@before.tech>
WalkthroughOhayo, sensei! This pull request introduces various modifications across several files, primarily enhancing documentation and refining existing methods without altering their core functionality. Changes include updated comments for clarity in the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (4)
crates/sozo/ops/src/migrate/mod.rs (1)
771-771
: Ohayo sensei! Consider rephrasing the comment for clarity.Rewriting the comment can improve understanding.
Suggested change:
-// We want to wait for the receipt to be able to print the -// world block number. +// Wait for the receipt to retrieve and display the world block number.crates/katana/runner/src/lib.rs (1)
254-254
: Ohayo sensei! Clarify the documentation comment.Enhancing the comment for better clarity.
Suggested change:
/// Determines the default program path for the katana runner based on the KATANA_RUNNER_BIN -/// environment variable. If not set, try to use katana from the PATH. +/// environment variable. If not set, it defaults to "katana" in the system PATH.crates/katana/rpc/rpc/src/utils/events.rs (1)
340-340
: Ohayo sensei! Correct minor grammatical issues in the comment.Adjusting the comment for proper grammar and punctuation.
Suggested change:
-// start from the same event pointed by the -// current cursor.. +// Start from the same event pointed to by the current cursor.crates/katana/primitives/src/chain_spec.rs (1)
76-76
: Ohayo sensei! Capitalize the comment for consistency.Ensuring consistency in comment styling.
Suggested change:
-// this method will include the ETH and STRK fee tokens, and the UDC +// This method will include the ETH and STRK fee tokens, and the UDC
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (4)
crates/katana/primitives/src/chain_spec.rs
(1 hunks)crates/katana/rpc/rpc/src/utils/events.rs
(1 hunks)crates/katana/runner/src/lib.rs
(1 hunks)crates/sozo/ops/src/migrate/mod.rs
(1 hunks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rusttech for your contribution. FYI, contributions that only fix comments typos are not eligible for only dust rewards. 👍
Signed-off-by: rusttech <gopher@before.tech>
Description
remove redundant words in comment
Related issue
Tests
Added to documentation?
Checklist
scripts/prettier.sh
,scripts/rust_fmt.sh
,scripts/cairo_fmt.sh
)scripts/clippy.sh
,scripts/docs.sh
)Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Documentation
Refactor
KatanaRunner
to improve setup flexibility.