Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'react_native_ios_utilities/RNIBaseViewShadowNode.h' file not found in Expo SDK 52 (react-native-ios-context-menu@next) #120

Closed
coolsoftwaretyler opened this issue Dec 15, 2024 · 1 comment · Fixed by #121

Comments

@coolsoftwaretyler
Copy link
Contributor

Hey @dominicstop - I haven't figured out the root cause of this, but react-native-ios-context-menu@3.0.0-18 seems to have some more missing headers when running Expo SDK 52, which uses the new architecture by default.

Here's a reproducer: https://github.com/coolsoftwaretyler/react-native-ios-utilities-missing-header-expo-52-reproducer

From that project, if you:

npm install
npx expo prebuild
npm run ios

You'll get the following build error:

› Executing react-native Pods/React-FabricComponents » [CP-User] [RN]Check rncore
› Compiling react-native Pods/React-RCTFabric » RCTThirdPartyFabricComponentsProvider.mm
› Packaging react-native Pods/React-RCTFabric » libReact-RCTFabric.a
› Compiling react-native-ios-context-menu Pods/react-native-ios-context-menu » RNIContextMenuButtonViewManager.mm
› Compiling react-native-ios-context-menu Pods/react-native-ios-context-menu » RNIContextMenuViewManager.mm
› Compiling react-native-ios-context-menu Pods/react-native-ios-context-menu » RNIContextMenuButton.mm

❌  (node_modules/react-native-ios-context-menu/ios/RNIContextMenuButton/RNIContextMenuButtonShadowNode.h:11:10)

   9 | #pragma once
  10 | 
> 11 | #include <react_native_ios_utilities/RNIBaseViewShadowNode.h>
     |          ^ 'react_native_ios_utilities/RNIBaseViewShadowNode.h' file not found
  12 | #include <react_native_ios_utilities/RNIBaseViewProps.h>
  13 | #include <react_native_ios_utilities/RNIBaseViewEventEmitter.h>
  14 | 

› Compiling react-native-ios-context-menu Pods/react-native-ios-context-menu » RNIContextMenuView.mm

❌  (node_modules/react-native-ios-context-menu/ios/RNIContextMenuView/RNIContextMenuViewShadowNode.h:11:10)

   9 | #pragma once
  10 | 
> 11 | #include <react_native_ios_utilities/RNIBaseViewShadowNode.h>
     |          ^ 'react_native_ios_utilities/RNIBaseViewShadowNode.h' file not found
  12 | #include <react_native_ios_utilities/RNIBaseViewProps.h>
  13 | #include <react_native_ios_utilities/RNIBaseViewEventEmitter.h>
  14 | 

    Run script build phase '[CP-User] Generate app.config for prebuilt Constants.manifest' will be run during every build because it does not specify any outputs. To address this issue, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'EXConstants' from project 'Pods')
    Run script build phase '[CP-User] [Hermes] Replace Hermes for the right configuration, if needed' will be run during every build because it does not specify any outputs. To address this issue, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'hermes-engine' from project 'Pods')

› 2 error(s), and 4 warning(s)

Running version 3.0.0-18 of this library, and version 5.0.0-52 of react-native-ios-context-menu.

@coolsoftwaretyler coolsoftwaretyler changed the title 'react_native_ios_utilities/RNIBaseViewShadowNode.h' file not found in Expo SDK 52 (@next version) 'react_native_ios_utilities/RNIBaseViewShadowNode.h' file not found in Expo SDK 52 (react-native-ios-context-menu@next) Dec 15, 2024
@coolsoftwaretyler
Copy link
Contributor Author

Changing those headers back to:

#include <react-native-ios-utilities/RNIBaseViewShadowNode.h>
#include <react-native-ios-utilities/RNIBaseViewProps.h>
#include <react-native-ios-utilities/RNIBaseViewEventEmitter.h>

Seems to fix the issue.

I think we might just need to extend the changes 01ba1f3 to a few more files. I will see if I can get a working patch and submit a PR later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant