Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #120 by updating the header paths to support both hyphens and underscores.
The first commit, 828bc0f, fixes it the way we've been writing them up until now.
In cd7840e, I wrote a macro to clean up those imports. Since we can't encapsulate
#if
statements in the preprocessor, it's not as clean as I'd like, but it does reduce all of the conditionals in each file.You can see the first patch working in my reproducer repo, at this commit: coolsoftwaretyler/react-native-ios-utilities-missing-header-expo-52-reproducer@bfe92e1
You can see the second patch working in the reproducer at: coolsoftwaretyler/react-native-ios-utilities-missing-header-expo-52-reproducer@8dd3133
To verify:
rm -rf node_modules/ android/ ios/
for a clean startnpm install
npm run patch
npx expo prebuild
npm run ios
Build should work.