Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android compiling issue #113

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

jongbelegen
Copy link
Contributor

Fix Android Build Issues with New React Native Architecture

Problem

When using this iOS-specific package with the new React Native architecture, Android builds fail with a Kotlin compilation error:

Execution failed for task ':react-native-ios-context-menu:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
   > Compilation error. See log for more details

This occurswhen using the new architecture-compatible versions:

  • react-native-ios-utilities: 5.0.0-46
  • react-native-ios-context-menu: 3.0.0-10

Solution

Since this package is iOS-specific, I removed the Android folder to prevent Android build errors.

This change is particularly relevant for projects using Zeego, which depends on this package.

@coolsoftwaretyler
Copy link
Contributor

Hi @dominicstop - I hope it's not a bother for me to ping you on this one directly. I really appreciate all the work you're doing in the @next branch of this library.

Any chance you could merge this in? I've been using it from my personal fork with success. The change is pretty minor and easy to validate, and it would be awesome if I could get off the fork and back onto the @next versions to keep up with what you've got going on.

Thanks in advance.

@dominicstop dominicstop merged commit b9963c7 into dominicstop:master Dec 12, 2024
@dominicstop
Copy link
Owner

hello, @jongbelegen thank you for contributing to this repo; i've only recently started to understand how to use PR's, so i apologize that it took a while to merge your changes (i've released 3.0.0@18 containing your patch)

my emails are a mess, so i often miss contributions and errors, thank you @coolsoftwaretyler for letting me know

@jongbelegen
Copy link
Contributor Author

@dominicstop Thanks for your awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants