Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the Attributes map, instead of using the map provided by the user, preventing two maps from actually being the same reference (issue #177) #179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tzq0301
Copy link
Contributor

@tzq0301 tzq0301 commented Jun 15, 2024

In issue #177, every new Vertex will contain the same map declared in redVertexAttr, which causes the unexcepted behaviour in the issue.

…the user, preventing two maps from actually being the same reference (issue dominikbraun#177)
@tzq0301 tzq0301 changed the title Fix directly use same map fix: update the Attributes map, instead of using the map provided by the user, preventing two maps from actually being the same reference (issue #177) Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant