Export weldPrimitive

[marwie]

It would be nice to be able to re-use the weld and weldOnly methods for individual primitives without having to copy the code in our own extension/plugin.

I'm not sure if you'd want to export those methods and increasing the API surface. I would like to make a similar PR for the squoosh and/or toktx methods if you're generally open for that

[donmccurdy]

Thanks @marwie! I like the idea of exporting per-primitive functions. Per #565 (comment) I would vote to name the exported function something like weldPrimitive(document, prim, options), with tolerance=0 being equivalent to weldOnly.

I would like to make a similar PR for the squoosh and/or toktx methods if you're generally open for that...

Maybe! Currently most of the code in these functions has to do with choosing which textures to update. The code to compress textures (see #752) is actually pretty short:

const buffer = await encoder(texture.getImage())
  .toFormat('png')
  .toBuffer();
texture.setImage(BufferUtils.toView(buffer))

Especially since the current encoders (squoosh and toktx) have some major limitations, I'm a little worried that wrapping that short per-texture code might lead people to depend on those wrappers rather than just choosing the right encoder for their needs. Happy to discuss the options here though, perhaps in a new issue? Also see:

• Replace @squoosh/lib with sharp #752

[marwie]

That's great. Applied your suggestion and moved the checks from the weld loop to the new weldPrimitive method

I understand that concern, especially since you're currently in the process of switching to sharp.
Maybe another alternative would be to be able to provide a callback via the options to modify the settings and/or processing altogether - the per slot / filter solution that e.g. toktx has right now doesn't really work for us very well since we want to allow users to control / override the compressions settings completely depending on the usecase.

I will open another issue for it later :)

[donmccurdy]

Looks great, thanks!