[WIP] Upgrade to prompt_toolkit 2.0 #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonathanslenders thanks for the PR! I hope to check it out in the next week or two. Congrats on 2.0. |
jonathanslenders
force-pushed
the
prompt-toolkit-2.0
branch
from
66ab823
to
3a32e19
Compare
jonathanslenders
force-pushed
the
prompt-toolkit-2.0
branch
from
3a32e19
to
3392b27
Compare
|
@donnemartin Is this ready for merge yet? |
|
just a side note: prompt-toolkit 3.0 has been released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to prompt_toolkit 2.0.
As far as I could test, it looks like most stuff is working fine.
I still have to check the
ignore_caseoption.