Update doorkeeper requirement from >= 5.5, < 5.8 to >= 5.5, < 5.9 #213
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [doorkeeper](https://github.com/doorkeeper-gem/doorkeeper) to permit the latest version. - [Release notes](https://github.com/doorkeeper-gem/doorkeeper/releases) - [Changelog](https://github.com/doorkeeper-gem/doorkeeper/blob/main/CHANGELOG.md) - [Commits](doorkeeper-gem/doorkeeper@v5.5.0...v5.8.0) --- updated-dependencies: - dependency-name: doorkeeper dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
@nbulaj Could you merge and release this so that we can update to doorkeeper v5.8? |
|
@toupeira Ok, good idea! I picked it; looks the error is still there. I was hoping to get this merged and released since we want to avoid having to vendor this gem soon. |
|
Hmm didn't it crash early before in the test setup because of the dependency problems? Now two tests are actually failing further along, see e.g. https://github.com/doorkeeper-gem/doorkeeper-openid_connect/actions/runs/11963588166/job/33354298453?pr=214 Did you test Doorkeeper 5.8 manually already? Could be that a change is breaking something in this gem. |
|
Yeah, the tests fail with Doorkeeper 5.7 as well. It looks like I thought it was a similar issue to doorkeeper-gem/doorkeeper#1742, but it doesn't seem to be the case. |
|
It looks like Doorkeeper v5.6.7 introduced doorkeeper-gem/doorkeeper#1676, which causes an error to return 400 instead of 200. |
|
We can close this in favor of #214. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/bundler/doorkeeper-gte-5.5-and-lt-5.9
branch
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
Updates the requirements on doorkeeper to permit the latest version.
Release notes
Sourced from doorkeeper's releases.
Changelog
Sourced from doorkeeper's changelog.
... (truncated)
Commits
be58d6bRelease 5.8.0 🎉4ca1d55Merge pull request #1732 from ransombriggs/fix-docker-file-tests5057044Merge pull request #1739 from stanhu/sh-support-dynamic-scopes4a0f7ceAdd entry in CHANGELOG.mdf71f4e4Merge branch 'main' into fix-docker-file-testsba5b258Exclude lib/doorkeeper/config.rb from Code Climate6c06b02Add support for dynamic scopesc113fa3Merge pull request #1742 from stanhu/sh-fix-broken-main40b9cb0Fix broken tests for older Rails versionsa33a90aRevert authorization_spec changesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)