Fix outdated ruby version in Dockerfile #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insecure Access Control (1)
More info on how to fix Insecure Access Control in Dockerfile. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
|
Added ruby 3.3 support to the testing matrix here: #1723 |
|
This issue should now be fixed: #1722 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the Dockerfile changes I needed in #1721 to get the Dockerfile to build on the latest Docker for Mac (and likely other docker versions)
It seems the Dockerfile is still using ruby 2.6, when the project dropped 2.6 support 19 months ago in #1622
I've gone straight ahead to Ruby 3.3.4 (latest stable), despite Doorkeeper not yet officially supporting Ruby 3.3 (I'll open a separate PR to add that to the testing matrix).