-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publisher restruct #615
Publisher restruct #615
Conversation
…trix and compile script.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #615 +/- ##
===========================================
+ Coverage 94.95% 95.48% +0.53%
===========================================
Files 36 41 +5
Lines 4853 5052 +199
Branches 930 939 +9
===========================================
+ Hits 4608 4824 +216
+ Misses 148 143 -5
+ Partials 97 85 -12 ☔ View full report in Codecov by Sentry. |
with: | ||
command: make test | ||
current_path: ${{ inputs.workpath }} | ||
attempt_limit: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest rerunning tests at the runner-level rather than restarting the whole suite.
https://pypi.org/project/pytest-rerunfailures/ could be added as a dependency in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing those issues! I'll merge this and publish a beta release for folks to confirm the fixes.
Rather large PR due to changes in the code structure of the publishers to make the code more maintainable, which fixes #574.
While fixing the test cases for the new structure, issues #581, #589, #601, #611 and #614 where also fixed.
Also noted that there are more python versions available, so I added 3.11 and 3.12 and they both pass all the tests so I saw no reason to remove them again.