Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DotNetStreamReference disposal remarks #33036

Merged
merged 6 commits into from
Jul 10, 2024
Merged

Improve DotNetStreamReference disposal remarks #33036

merged 6 commits into from
Jul 10, 2024

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Jul 10, 2024 •
edited by github-actions bot
Loading

@guardrex guardrex self-assigned this Jul 10, 2024
@guardrex
Copy link
Collaborator Author

@MackinnonBuck ... I may have hosed some of your explanation.

I was trying to distinguish the underlying stream, which I think is the System.IO.Stream, from the DotNetStreamReference.

MackinnonBuck
MackinnonBuck approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with some small suggestions 👍

aspnetcore/blazor/javascript-interoperability/call-javascript-from-dotnet.md Outdated Show resolved Hide resolved
aspnetcore/blazor/javascript-interoperability/call-javascript-from-dotnet.md Outdated Show resolved Hide resolved
aspnetcore/blazor/javascript-interoperability/call-javascript-from-dotnet.md Outdated Show resolved Hide resolved
@guardrex @MackinnonBuck
Apply suggestions from code review
6dbc7f5 
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
@MackinnonBuck
Copy link
Member

LGTM!

@guardrex guardrex merged commit 4a65b62 into main Jul 10, 2024
3 checks passed
@guardrex guardrex deleted the guardrex-patch-3 branch July 10, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MackinnonBuck MackinnonBuck MackinnonBuck approved these changes

Assignees

@guardrex guardrex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recommend patterns that avoid disposing DotNetStreamReference during transmission to the browser
2 participants
@guardrex @MackinnonBuck