Move to GitStaticAssets/4 #33050
Merged
Move to GitStaticAssets/4 #33050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rick-Anderson
commented
Jul 11, 2024
There was a problem hiding this comment.
@javiercn see my questions/remarks on when MapStaticAssets can replace UseStaticFiles
| @@ -44,7 +44,7 @@ | |||
|
|
|||
| app.UseHttpsRedirection(); | |||
|
|
|||
| app.UseStaticFiles(new StaticFileOptions | |||
| app.UseStaticFiles(new StaticFileOptions // | |||
There was a problem hiding this comment.
Can't use MapStaticAssets here.
There was a problem hiding this comment.
They are compatible, but depending on how app.UseRouting is used, one or the other will take precedence. For a simple sample like this, I would avoid updating it to use app.MapStaticAssets and probably create a separate section for it.
Comment on lines
386
to
387
| app.MapStaticAssets(); // Serve files from wwwroot with MapStaticAssets | ||
| app.UseStaticFiles(new StaticFileOptions |
There was a problem hiding this comment.
Probably shouldn't mix MapStaticAssets(); with UseStaticFiles
Rick-Anderson
commented
Jul 12, 2024
aspnetcore/fundamentals/static-files/samples/9.x/StaticFilesSample/Program.cs
Show resolved
Hide resolved
Rick-Anderson
commented
Jul 25, 2024
Comment on lines
275
to
+278
| > [!WARNING] | ||
| > `UseDirectoryBrowser` and `UseStaticFiles` can leak secrets. Disabling directory browsing in production is highly recommended. Carefully review which directories are enabled via `UseStaticFiles` or `UseDirectoryBrowser`. The entire directory and its sub-directories become publicly accessible. Store files suitable for serving to the public in a dedicated directory, such as `<content_root>/wwwroot`. Separate these files from MVC views, Razor Pages, configuration files, etc. | ||
| > `UseDirectoryBrowser` and `UseStaticFiles` <!-- but not MapStaticAssets --> can leak secrets. Disabling directory browsing in production is highly recommended. Carefully review which directories are enabled via `UseStaticFiles` or `UseDirectoryBrowser`. The entire directory and its sub-directories become publicly accessible. Store files suitable for serving to the public in a dedicated directory, such as `<content_root>/wwwroot`. Separate these files from MVC views, Razor Pages, configuration files, etc. | ||
|
|
||
| * The URLs for content exposed with `UseDirectoryBrowser` and `UseStaticFiles` are subject to the case sensitivity and character restrictions of the underlying file system. For example, Windows is case insensitive, but macOS and Linux aren't. | ||
| * The URLs for content exposed with `UseDirectoryBrowser`, `UseStaticFiles`, and `MapStaticAssets` are subject to the case sensitivity and character restrictions of the underlying file system. For example, Windows is case insensitive, but macOS and Linux aren't. |
There was a problem hiding this comment.
@javiercn please review these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #32782
V9 URL
DON"T USE AUTO GENERATED, it defaults to V8, not V9
Internal previews