Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Include not-latest-version or not-ga-yet #33155

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

wadepickett
Copy link
Contributor

@wadepickett wadepickett commented Jul 24, 2024

Contributes to #32886

1st of several PR's.

Addresses all applicable files from folder in alpha order through fundamentals/.
Skipping the following folders:

  • blazor/ (guardrex has already done this one.
  • diagnostics/ These topics didn't seem like they would fit the need.

Docs with monikerRange: '< aspnetcore-8.0' or without any monikerRange at the top of the page get:

[!INCLUDE[](~/includes/not-latest-version.md)]

Docs with monikerRange: '>= aspnetcore-8.0' get:

<!-- UPDATE 9.0 Activate after release and INCLUDE is updated

[!INCLUDE[](~/includes/not-latest-version.md)]

-->

Docs with monikerRange: '>= aspnetcore-9.0' get:

[!INCLUDE[](~/includes/not-ga-yet.md)]

<!-- Uncomment this when 9.0 is the default value in the version selector and delete not-ga-yet.md

[!INCLUDE[](~/includes/not-latest-version.md)] 

-->

Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
aspnetcore/client-side/dotnet-interop.md Run .NET from JavaScript
aspnetcore/data/ef-rp/crud.md Part 2, Razor Pages with EF Core in ASP.NET Core - CRUD
aspnetcore/data/ef-rp/intro.md [Visual Studio](https://review.learn.microsoft.com/en-us/aspnet/core/data/ef-rp/intro?branch=pr-en-us-33155)
aspnetcore/fundamentals/aot/native-aot-tutorial.md [Visual Studio](https://review.learn.microsoft.com/en-us/aspnet/core/fundamentals/aot/native-aot-tutorial?branch=pr-en-us-33155)
aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rdg001.md "RDG001: Unable to resolve route pattern"
aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rdg002.md RDG002: Unable to resolve endpoint handler
aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rdg003.md aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rdg003
aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rdg004.md RDG004: Unable to resolve anonymous type
aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rdg005.md "RDG005: Invalid abstract type"
aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rdg006.md RDG006: Invalid constructor parameters
aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rdg007.md aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rdg007
aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rdg008.md RDG008: Multiple public constructors
aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rdg009.md "RDG009: Invalid nested AsParameters"
aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rdg010.md RDG010: InvalidAsParameters Nullable
aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rdg011.md aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rdg011
aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rdg012.md RDG012: Unable to resolve inaccessible type
aspnetcore/fundamentals/aot/request-delegate-generator/diagnostics/rdg013.md "RDG013: Invalid source attributes"
aspnetcore/fundamentals/aot/request-delegate-generator/rdg-ids.md ASP.NET Core Request Delegate Generator (RDG) diagnostics
aspnetcore/fundamentals/aot/request-delegate-generator/rdg.md aspnetcore/fundamentals/aot/request-delegate-generator/rdg
aspnetcore/fundamentals/best-practices.md ASP.NET Core Best Practices
aspnetcore/fundamentals/change-tokens.md Detect changes with change tokens in ASP.NET Core
aspnetcore/fundamentals/environments.md Use multiple environments in ASP.NET Core
aspnetcore/fundamentals/file-providers.md aspnetcore/fundamentals/file-providers
aspnetcore/fundamentals/host/generic-host.md .NET Generic Host in ASP.NET Core
aspnetcore/fundamentals/host/platform-specific-configuration.md Use hosting startup assemblies in ASP.NET Core
aspnetcore/fundamentals/host/web-host.md ASP.NET Core Web Host
aspnetcore/fundamentals/http-context.md Access HttpContext in ASP.NET Core
aspnetcore/fundamentals/http-requests.md aspnetcore/fundamentals/http-requests
aspnetcore/fundamentals/minimal-apis/aspnetcore-openapi.md Get started with Microsoft.AspNetCore.OpenApi
aspnetcore/fundamentals/native-aot.md ASP.NET Core support for Native AOT

Note

This table shows preview links for the 30 files with the most changes. For preview links for other files in this PR, select OpenPublishing.Build Details within checks.

@wadepickett wadepickett self-assigned this Jul 24, 2024
@wadepickett
Copy link
Contributor Author

wadepickett commented Jul 24, 2024

@tdykstra, what should we do with topics that have no moniker versioning at all except perhaps for say, 2.0 inline for some specific paragraph. Do we leave those out of this for now? (I left them out of this 1st PR)
Here is an example from this build:
https://review.learn.microsoft.com/en-us/aspnet/core/client-side/bundling-and-minification?view=aspnetcore-9.0&branch=pr-en-us-33155

@wadepickett wadepickett marked this pull request as ready for review July 24, 2024 18:40
@tdykstra
Copy link
Contributor

@tdykstra, what should we do with topics that have no moniker versioning at all except perhaps for say, 2.0 inline for some specific paragraph. Do we leave those out of this for now? (I left them out of this 1st PR) Here is an example from this build: https://review.learn.microsoft.com/en-us/aspnet/core/client-side/bundling-and-minification?view=aspnetcore-9.0&branch=pr-en-us-33155

In the PR description box:
Docs with monikerRange: '< aspnetcore-8.0'
-->
Docs with monikerRange: '< aspnetcore-8.0' or without monikerRange

@wadepickett
Copy link
Contributor Author

wadepickett commented Jul 24, 2024

Thanks! I'll update the issue and PR descriptions. The tool I wrote for processing these was not (correction) making that assumption and those without a monikerRange at all at the top of the file will be included on the next PR.

@wadepickett
Copy link
Contributor Author

If these look good to you and I can merge, then I will finish with the other PR's today, around 50 or so file changes per PR.

@wadepickett
Copy link
Contributor Author

wadepickett commented Jul 24, 2024

Just tested two topics that without MonikerRanges at the top, the include file errors, so I backed them out so we can at least get this PR approved and merged.

In the next PR I will have to figure out where and why the include is breaking down on the case with no monikerRange at the top metadata.

I have the feeling it would have been better to not to try to handle any logic in the include itself for versioning, and just left that to tooling and regx for adding or removing an include with just the text needed.

I am guessing to get the files without monikerRanges to work, that I will need to insert a monikerRange in the metadata so it is explicit. I'll see in next PR. A best practice I suppose to have monikerRanges in the metadata anyway.

@wadepickett wadepickett merged commit ae3ee11 into main Jul 24, 2024
3 checks passed
@wadepickett wadepickett deleted the wadepickett/32886AddNotLatestVersionOrNotGA branch July 24, 2024 23:35
@tdykstra
Copy link
Contributor

I have the feeling it would have been better to not to try to handle any logic in the include itself for versioning, and just left that to tooling and regx for adding or removing an include with just the text needed.

Feel free to try that approach and if it works out better we can change it everywhere with a regex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants