-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced JSImport/JSExport guidance #33156
Enhanced JSImport/JSExport guidance #33156
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Thanks ... I'll make updates. For the future, note that we use GH's suggestion feature for line changes, which is efficient for change requests on PRs. UPDATE: Done! ... You can let me know if further changes are needed. Otherwise, I think Pavel and/or Mackinnon will take a look at the technical aspects. I think Dan will let us know if the overall content layout makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding some thoughts - I think we should wait for a review from @pavelsavara before merging.
aspnetcore/blazor/javascript-interoperability/import-export-interop.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
I still need an answer on if the .NET WebAssembly build tools option must be included for Visual Studio use (the Blazor ariticle). The client-side article states (emphasis added) ...
Brings in the related MSBuild targets implies that devs need the tools for the Blazor article experience with VS. If the client-side article is incorrect, then let me know 👂, and I'll 🔪 that out of both articles. |
Empirically tested, it's not needed., I removed it from the machine. To see the browser WASM template in VS we can use:
and having no However, you are asking about "Blazor experience" while the quoted step is about "WebAssembly Browser App", so please, review if I did not misunderstand your question, I am testing WebAssembly Browser App. |
Co-authored-by: SerratedSharp <97156524+SerratedSharp@users.noreply.github.com>
Thanks @SerratedSharp ... Sorry that I didn't see your remark from three days ago. Thanks for providing the updates. I merged all of them except for the one that you're discussing with @pavelsavara on adding back "ES6," Next, I'll pick back up with testing within the next couple of days, hopefully tomorrow morning 🤞. |
@SerratedSharp ... That licked it 🎉 ... Anything else for this? |
@maraf any feedback ? See also https://github.com/dotnet/blazor-samples/tree/main/8.0/WASMBrowserAppImportExportInterop |
Unrelated to this PR, I'm thinking that Blazor users should be nudged to use workload and compatible flags/features which improve performances/size. Are the samples the right place ? Should we demo Blazor compatible things like Should there be AOT demo ? |
Not necessarily an AOT "demo" (i.e., sample app), but we do have AOT coverage. Generally, when you write "demo" IDK if you mean "sample app" or just "coverage." I'm trying to limit the number of sample apps. They're time-consuming to maintain, and there are a bunch of them now ... https://github.com/dotnet/blazor-samples/tree/main/8.0 They all must be updated every release. |
I was thinking sample, maybe one of the existing samples could have it all enabled ? No pressure, just idea. |
I'm not feel'in it because ...
|
That's DX of a lazy developer ;)
AOT is faster in execution, but much slower for dev loop or first download. That's something that our developers need to understand (and experience).
Correct, it's not good as default, you need to know what you are doing. |
@danroth27 must address it. It's not really a 🦖 call. Dan, see the last few remarks. |
@maraf ... Do you want to review this? @danroth27 ... Do you want to reverse your earlier decision on not enabling AOT OOB for one or more of our WASM sample apps? Even if you do want to reverse that decision, it would only be for the |
I don't see a need to have a sample for AOT given that the only code change needed to enable AOT is setting the |
Thanks, @danroth27. I'm just waiting on feedback from @maraf. I think we can merge this after his review/updates. |
Fixes #32001
Fantastic article @SerratedSharp! 🎷
Notes:
Internal previews