-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Aspire from 8.0.x to 9.0.x #4304
Conversation
@@ -15,6 +15,16 @@ | |||
<PackageReference Include="Microsoft.FluentUI.AspNetCore.Components" /> | |||
<PackageReference Include="Microsoft.FluentUI.AspNetCore.Components.Icons" /> | |||
<PackageReference Include="TextCopy" /> | |||
|
|||
<!-- Pins that can go away once we upgrade to .NET 9.0 centrally --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have plans to move to 9.0 since it's not LTS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to move the repo to 9.0 and it's problematic with darc still targeting 6.0 (which I don't know if we can bump).
However this PR shows that Blazor WASM compiled by 9.0 targeting 8.0 does not work well if it has libraries inside targeting older. I found quite a few threads on GitHub about problems like these.
For some reason I don't see any work that the pipeline did, I just see it's green. A UI bug? |
I reverted some of the changes and am trying to deploy it here: I can even try staying on the 8.0 SDK and using the 9.0 Aspire but not sure that is supported |
@dkurepa I think it works like this now. Trying a deployment to INT too but works locally |
This upgrade means we won't need the Aspire .NET workload to be installed. Aspire will only work through NuGet packages. This means new SDK won't force us to new Aspire and we can shave some time off of our builds as the workload install takes some time.
Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2613804