Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for odata v9 #1108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

arabelaa
Copy link

@arabelaa arabelaa commented Sep 2, 2024

Add support for Microsoft.AspNetCore.OData v9

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Issue ref: #1103

With the release of Microsoft.AspNetCore.OData 9 https://devblogs.microsoft.com/odata/announcing-asp-net-core-odata-9-official-release/, I thought it's time to have support in aspnet-api-versioning.

@arabelaa
Copy link
Author

arabelaa commented Sep 2, 2024

@dotnet-policy-service agree company="UiPath"

@arabelaa arabelaa marked this pull request as ready for review September 2, 2024 10:45
@arabelaa
Copy link
Author

arabelaa commented Sep 2, 2024

@commonsensesoftware can you please have a look?

@ct-jby
Copy link

ct-jby commented Oct 6, 2024

Can someone review and merge please ?

We'd like to be able to use odata v9 with api versioning

@mike-bagheri
Copy link

mike-bagheri commented Oct 8, 2024

Can someone please merge this PR

@commonsensesoftware
Copy link
Collaborator

Apologies for the delay. I've been a bit backed up by my day job and personal life of late. To be clear, I am the someone to review and merge the change. This entire repo from code to docs is managed by a single person - me (and always has been).

I appreciate the urgency and ❤️ that someone has put forth the effort to create a PR. Honestly, that's pretty infrequent in this repo. I need to spend some time to consider the full impact; especially, since this PR intends to bump the major version. .NET 9 is just around the corner and I'd prefer that all the major version numbers line up, even though I realize OData doesn't release on the standard cadence. If OData was more stable, I'd leave the major version open, which may have negated this change; however, I've been bitten by its breaking changes countless times.

You're not being ignored. Releases need to be of the highest quality. My mental plan of action is as follows:

  • Determine if this change can be multi-targeted to stay within the 8.x version
  • If not, consider a stable 9.0-preview so 9.0 can release consistently across the board

I'll do what I can to carve out some time over the next days to flush things out get this change rolling forward. Thanks for your patience.

@jvsancho80
Copy link

Net9 is here. When version to support Net 9. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants