Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disabled WebView Cookie Tests #24978

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix disabled WebView Cookie Tests #24978

wants to merge 3 commits into from
+107 −49

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Sep 28, 2024

Issues Fixed

Fixes #24913

Screenshot 2024-09-28 at 01 05 47

@kubaflo kubaflo requested a review from a team as a code owner September 28, 2024 00:12
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Sep 28, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jfversluis
Copy link
Member

jfversluis commented Sep 30, 2024 •
edited
Loading

/azp run

@azure-pipelines Azure Pipelines

This comment was marked as outdated.

Sign in to view
jfversluis
jfversluis requested changes Sep 30, 2024
View reviewed changes
Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some related, relevant test failures

@kubaflo
Copy link
Contributor Author

kubaflo commented Sep 30, 2024

@jfversluis can we try again please?

@azure-pipelines Azure Pipelines

This comment was marked as outdated.

Sign in to view
@kubaflo
Copy link
Contributor Author

kubaflo commented Sep 30, 2024

@jfversluis some android tests started to pass, all of them passed on iOS. I have a suspicion that LoadingPageWithoutCookiesSpecifiedDoesntCrash test might be a problem 🤔

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kubaflo
Copy link
Contributor Author

kubaflo commented Sep 30, 2024 •
edited
Loading

Screenshot 2024-09-30 at 13 30 43 Screenshot 2024-09-30 at 15 03 27

Some progress. I'm not sure why LoadingPageWithoutCookiesSpecifiedDoesntCrash doesn't work though. And why Windows don't cooperate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfversluis jfversluis jfversluis requested changes

@Eilon Eilon Awaiting requested review from Eilon Eilon is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@PureWeen PureWeen Awaiting requested review from PureWeen

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
community ✨ Community Contribution t/housekeeping ♻︎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix disabled WebView Cookie Tests
2 participants
@kubaflo @jfversluis