Disallowing using COMPlus_ has the prefix for environment variables. #3815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0d3885d.
Maoni0
reviewed
Jan 30, 2024
| @@ -2,12 +2,12 @@ runs: | |||
| baseline: | |||
| corerun: C:\CoreRuns\Empty\ | |||
| environment_variables: | |||
| COMPlus_GCServer: 1 | |||
| DOTNET_GCServer: 1 | |||
There was a problem hiding this comment.
actually this is gcServer instead of GCServer
Maoni0
reviewed
Jan 30, 2024
Co-authored-by: Maoni Stephens <Maoni0@users.noreply.github.com>
|
what is the motivation for this change? Just to keep things consistent? |
NativeAOT doesn't allow for COMPlus variables and we didn't want to add additional logic in the infra to differentiate. considering our testing is now .NET 6 and onwards, we decided to exclusively make use of DOTNET_*. |
|
makes sense |
mrsharm
commented
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallowing using COMPlus_ has the prefix for environment variables and therefore, this PR entails: