Benchmarks_local disable terminating of all dotnet processes #3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…switched default of killing dotnet to not killing dotnet. Added arguments to reenable each of these options, but this new default will allow the script to run completely while also using the machine for other dotnet/msbuild tasks without interruption.
…ed the artifact path to include the framework version being run so you can run net9.0 and then net8.0.
… and enable-msbuild-node-reuse arguments, also updated dont-kill-dotnet-processes with deprecation information as it is now the default flow.
…shouldn't need it as the problem was due to dotnet_mono conflicts.
LoopedBard3
requested review from
sblom,
cincuranet,
DrewScoggins and
caaavik-msft
cincuranet
approved these changes
Feb 15, 2024
|
Failures are unrelated, merging. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, due to msbuild node reuse, the artifact build steps would occasionally fail due to files still being "in use" when building more than 1 commit for testing. To get around this the benchmarks local script terminated any potential dotnet file holders with the side affect of terminating other unrelated dotnet tasks on the machine. This commit updates the default of the script to disable msbuild Node reuse (found via https://stackoverflow.com/questions/13510465/the-mystery-of-stuck-inactive-msbuild-exe-processes-locked-stylecop-dll-nuget/13510466#13510466, thanks @caaavik-msft) which should keep this problem from occurring. A side effect of this change is that builds may be slower, so the option to enable node reuse is available.
The other primary update includes the adding of a force terminate option if we find edge cases where we still hit problems due to running processes. Minor updates include consolidating get_mono_corerun and forced cleaning of dotnet_mono folder to avoid a state with intermixed dotnet_mono folders from between runs.