Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor new notebook #4298

Merged
merged 7 commits into from
Jul 3, 2024
Merged

Factor new notebook #4298

merged 7 commits into from
Jul 3, 2024

Conversation

markples
Copy link
Member

@markples markples commented Jul 3, 2024 •
edited
Loading

This allows an investigation to start with just #!import BenchmarkAnalysis.dib and dev iteration on the reports to then add #!import Reports.dib.

This should be no-diff other than the factoring except for the following:

  • Adding #!import commands
  • Factor and reduce import/using lists
  • Whitespace (lint errors) in the documentation md file

mrsharm
mrsharm approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@mrsharm mrsharm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markples markples merged commit d2a8af2 into dotnet:main Jul 3, 2024
4 of 5 checks passed
@markples markples deleted the notebook-refactor2 branch July 5, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsharm mrsharm mrsharm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markples @mrsharm