Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partition helix test runs using historical execution time data #62138
Partition helix test runs using historical execution time data #62138
Changes from all commits
561d57f
45d49dd
1bdef98
b428661
eec06a9
e0a2316
43991a3
04290ae
f4df81b
8ffd275
a8c75f3
4e120ec
29ba5cf
6b96c54
e1e6c84
26ee734
aca2010
7b52db0
f1626b7
3cc6540
a5b8007
006f3b1
0fc332b
40b2664
9fc71af
1bd0e1c
5eda6de
c66fe12
0519c06
fb0c6fc
6b0d0b8
ff5c993
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hard coding seems wrong. Instead I think we should be passing down the desired TFM or doing some other filtering at the calling process. Having this hard coded here can lead to hard to track down issues later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can pass this in from the script / yaml if you'd prefer, but I'll still have to either list the tfm's we want to discover (which could change if we start multi-targeting a different tfm for example) or the ones we want to exclude (which could change as well).
Aternatively, if you have a suggestion on some metadata I could look at in the assembly to determine if its compatible with the current platform, that would be preferrable, I wasn't able to immediately come up with a great way.
I realize now my comment here got lost in some of the changes - but basically the unix build builds multitargeted projects which ends up building the net472 dlls. RUnning discovery on them on unix fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment here - but didn't end up changing it. Some notes
I could also consider using SRM to check if the TargetFramework attribute contains 'NETFramework' but not sure if that is worth doing. Happy to hear other thoughts.