Skip to content

Commit

Permalink
[test][tvos] Disable InvalidIVSizes overflow case for tvos (#76725)
Browse files Browse the repository at this point in the history
This test has flakily caused app crashes on tvOS arm64 lanes. dotnet/arcade#11167
When the app crashes, it was observed that of the last tests ran, there commonly was only 2 InvalidIVSizes see
https://gist.github.com/mdh1418/563ce4066e16dfee055e0903e2c70a1e
https://gist.github.com/mdh1418/ed11c7ba361c3fdb8906e57034c58f90
https://gist.github.com/mdh1418/c831b807dc0d949bc01cdeee61a1d795

Whereas on a successful test suite run, there are 3.
https://gist.github.com/mdh1418/912914871d580475751d460719624224

Its suspected that the last test case is problematic, so disabling to make CI cleaner
  • Loading branch information
mdh1418 authored Oct 11, 2022
1 parent 16a2b51 commit 7215b38
Showing 1 changed file with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using Test.Cryptography;
using Microsoft.DotNet.XUnitExtensions;
using Xunit;

namespace System.Security.Cryptography.Encryption.Aes.Tests
Expand Down Expand Up @@ -161,7 +162,7 @@ public static void ValidCFBFeedbackSizes(int feedbackSize)
}
}

[Theory]
[ConditionalTheory]
[InlineData(64, false)] // smaller than default BlockSize
[InlineData(129, false)] // larger than default BlockSize
// Skip on .NET Framework because change is not ported https://github.com/dotnet/runtime/issues/21236
Expand All @@ -171,6 +172,9 @@ public static void InvalidIVSizes(int invalidIvSize, bool skipOnNetfx)
if (skipOnNetfx && PlatformDetection.IsNetFramework)
return;

if (PlatformDetection.IstvOS && invalidIvSize == 536870928)
throw new SkipTestException($"https://github.com/dotnet/runtime/issues/76728 This test case flakily crashes tvOS arm64");

using (Aes aes = AesFactory.Create())
{
aes.GenerateKey();
Expand Down

0 comments on commit 7215b38

Please sign in to comment.