Code

FileStream rewrite part II#48813

Code

Merged

adamsitnik merged 31 commits intodotnet:maindotnet/runtime:mainfrom adamsitnik:newWindowsFileStreamStrategyadamsitnik/runtime:newWindowsFileStreamStrategyCopy head branch name to clipboardMar 17, 2021

+3,086-844

Commits

Commits on Feb 25, 2021

• introduce WindowsFileStreamStrategy

  adamsitnik

  committed
  cd1698d

• introduce SyncWindowsFileStreamStrategy

  adamsitnik

  committed
  ad5b455

Commits on Feb 26, 2021

• introduce AsyncWindowsFileStreamStrategy

  adamsitnik

  committed
  a5ff09c

• some minor improvements after reading the code again

  adamsitnik

  committed
  5a64215

• only DerivedFileStreamStrategy needs to have a reference to FileStream

  Show description for e27ce6c
  adamsitnik

  committed
  e27ce6c

• implement ReadByte and WriteByte to make new windows strategies fully functional

  Show description for 3f84bd5
  adamsitnik

  committed
  3f84bd5

• implement FlushAsync for no buffering strategies as nop to get Flush_NothingToFlush_CompletesSynchronously passing

  adamsitnik

  committed
  402cf65

• use the new strategies when buffering is not enabled

  adamsitnik

  committed
  9a30387

Commits on Mar 1, 2021

• introduce BufferedFileStreamStrategy

  adamsitnik

  committed
  f34cb02

• fix the Mono build

  adamsitnik

  committed
  fb5b611

Commits on Mar 2, 2021

• use the Legacy strategy by default for now, add tests for the other implementation

  adamsitnik

  committed
  b1decbf

• restore old file name to make it easier to review the code (as diff within the file, not a removal and addition)

  adamsitnik

  committed
  8d58437

• Don't set the buffer to null, to avoid a NullReferenceException

  Show description for 33e6b8e
  adamsitnik

  committed
  33e6b8e

• fix the browser build?

  adamsitnik

  committed
  77b6d97

• reverting the flushing changes as it looks that they have introduced a bug

  adamsitnik

  committed
  33c7c83

Commits on Mar 3, 2021

• 0 bytes reads are OK only for FileStream when the read buffer is empty

  adamsitnik

  committed
  60cd6e7

• simplify the source code by removing some of the optimizations that are not providing too much gains

  adamsitnik

  committed
  e8d6f77

Commits on Mar 10, 2021

• Apply suggestions from code review

  Show description for 7913ebf
  

  3 peopleauthored
  7913ebf

• address code review feedback

  adamsitnik

  committed
  3f6b541

• use ThrowHelper in other places in System.IO

  adamsitnik

  committed
  75569e3

• Merge remote-tracking branch 'upstream/main' into newWindowsFileStreamStrategy

  adamsitnik

  committed
  9a4c15a

• update test projects based on most recent changes in main branch

  adamsitnik

  committed
  19bb524

• fix a path that I've broken in previous commit

  adamsitnik

  committed
  dd8c4b9

• revert the ResourceReader change that broke Mono build

  adamsitnik

  committed
  737c73c

• restore old test behavior, but keep it only for Legacy FileStream

  adamsitnik

  committed
  4a5497a

Commits on Mar 11, 2021

• move buffering logic to BufferedFileStreamStrategy

  adamsitnik

  committed
  f01948d

• use buffering code from LegacyFileStream

  adamsitnik

  committed
  3c152b7

• Merge remote-tracking branch 'upstream/main' into newWindowsFileStreamStrategy

  Show description for d52293b
  adamsitnik

  committed
  d52293b

• set _writePos = 0 in explicit way in Dispose so WriteByte hot path can rely on simple check

  adamsitnik

  committed
  e54edc5

Commits on Mar 12, 2021

• fix ReadAsync and WriteAsync bugs that were discovered by the checked config test runs

  adamsitnik

  committed
  0294191

• move the finalization logic to the finalizer

  adamsitnik

  committed
  c73558a