Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono][aot] Enable dedup by default for iOS #81319
[mono][aot] Enable dedup by default for iOS #81319
Changes from all commits
8576ca8
f4ffee1
eab1dbb
5af578a
d0f97f5
84f8a2c
0671c4c
2ef8ebd
46ec344
b9cdd48
2816e7b
84fe588
2dadd01
6552718
fbc0a92
26258b7
cc5819c
af43e01
8ebc6a3
5d4bf27
49fc88d
063cdc2
9b313fe
9d90655
c2b0cc5
ad32810
35e9493
9ae4957
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that emit_and_reloc_code () is never used on wasm, so this shouldn't be neccessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, disabled for now. I've added a tracking issue for it as additional size savings might be achieved - #82224
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this skipped ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dedup_skip_methods
was used in previous implementation wherecfg->skip
flag was set for a dedup method. Current implementation uses hash tablededup_methods
. With this function enabled, it might skip methods not added todedup_methods
and thus not emitting them in the dedup AOT image.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this skipped ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current implementation dedup methods based on a set of predefined rules. During the compilation, shared methods are emitted in corresponding AOT image while inflated instances are emitted in dedup AOT image. During the runtime, the shared method can't be retrieved as it was searched in the dedup AOT image.
Here is an example. During the compilation, the following runtime invoke wrappers are emitted in the dedup AOT image, while generic wrapper
(wrapper runtime-invoke) void object:runtime_invoke_dynamic (intptr,intptr,intptr,intptr)
is emitted in a corresponding AOT image.During the runtime,
(wrapper runtime-invoke) void object:runtime_invoke_dynamic (intptr,intptr,intptr,intptr)
was searched in the dedup AOT image as it isRUNTIME_INVOKE_WRAPPER
, but not emitted in the dedup AOT image.