Early out in impMarkInlineCandidate for minopts #86949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsMitigates 0.2% MinOpts TP regression from #86551
|
|
Diffs PTAL @jakobbotsch @dotnet/jit-contrib It not only mitigates, but also improves on top. |
hughbe
reviewed
May 31, 2023
| @@ -6204,6 +6204,18 @@ void Compiler::impMarkInlineCandidate(GenTree* callNode, | |||
| CORINFO_CALL_INFO* callInfo, | |||
| IL_OFFSET ilOffset) | |||
| { | |||
| if (!opts.OptEnabled(CLFLG_INLINING)) | |||
| { | |||
| /* XXX Mon 8/18/2008 | |||
There was a problem hiding this comment.
Do we need the date in the comment here?
There was a problem hiding this comment.
I don't think so, but I only moved an existing code a bit up, didn't change it
AndyAyersMS
approved these changes
May 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates 0.2% MinOpts TP regression from #86551