-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove win-arm RIDs #87074
Remove win-arm RIDs #87074
Conversation
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsI encountered some errors trying to build runtime with a preview6 SDK due to I wasn't sure if it's safe to remove these. I think it should be ok, because we shouldn't need to fall back from runtime/src/libraries/Microsoft.NETCore.Platforms/src/runtime.json Lines 4264 to 4268 in f4ef5c8
runtime/src/libraries/Microsoft.NETCore.Platforms/src/runtime.compatibility.json Lines 11082 to 11087 in f4ef5c8
I assume these should stay as-is since they are .net6/.net7 manifests: runtime/src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.net7.Manifest/WorkloadManifest.json.in Lines 475 to 481 in f4ef5c8
runtime/src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.net6.Manifest/WorkloadManifest.json.in Lines 444 to 450 in f4ef5c8
|
Failure is #82637 |
I encountered some errors trying to build runtime with a preview6 SDK due to
win-arm
RIDs in various projects. This scrubs most references towin-arm
that I found, with a few exceptions.I wasn't sure if it's safe to remove these. I think it should be ok, because we shouldn't need to fall back from
win-arm
assets if they are entirely unsupported, but I've left these references for now:runtime/src/libraries/Microsoft.NETCore.Platforms/src/runtime.json
Lines 4264 to 4268 in f4ef5c8
runtime/src/libraries/Microsoft.NETCore.Platforms/src/runtime.compatibility.json
Lines 11082 to 11087 in f4ef5c8
I assume these should stay as-is since they are .net6/.net7 manifests:
runtime/src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.net7.Manifest/WorkloadManifest.json.in
Lines 475 to 481 in f4ef5c8
runtime/src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.net6.Manifest/WorkloadManifest.json.in
Lines 444 to 450 in f4ef5c8