Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nativeaot][ios] Improve Native AOT test coverage on apple mobile platforms #89301

Merged

Conversation

kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Jul 21, 2023

This PR improves Native AOT test coverage on apple mobile platforms by enabling TestLinqExpressions test. Additionally, it enables tests execution on maccatalyst and adds more runtime tests from the subset.

Fixes #89168

@ghost
Copy link

ghost commented Jul 21, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR improves Native AOT test coverage on apple mobile platforms by enabling TestLinqExpressions test. Additionally, it enables tests execution on maccatalyst and adds more runtime tests from the subset.

Author: kotlarmilos
Assignees: kotlarmilos
Labels:

os-ios, area-NativeAOT-coreclr

Milestone: 8.0.0

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@ivanpovazan ivanpovazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslikesimulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslikesimulator

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 89301 in repo dotnet/runtime

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslikesimulator

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 89301 in repo dotnet/runtime

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike,runtime-ioslikesimulator

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 89301 in repo dotnet/runtime

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike,runtime-ioslikesimulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike,runtime-ioslikesimulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kotlarmilos
Copy link
Member Author

/azp run runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member Author

Any final thoughts before we merge this PR?

@jkotas
Copy link
Member

jkotas commented Aug 2, 2023

Any final thoughts before we merge this PR?

File issue on the disabled tests and add a link to it in all places where the tests are disabled? I assume that most of the tests are disabled due to bugs that we want to fix.

@kotlarmilos
Copy link
Member Author

Any final thoughts before we merge this PR?

File issue on the disabled tests and add a link to it in all places where the tests are disabled? I assume that most of the tests are disabled due to bugs that we want to fix.

Will do, thanks. The tests shouldn't necessarily fail, but the current infrastructure doesn't support multiple app bundles in a single test directory. In the case of Mono, a single app bundle is created, and test wrappers are generated to pass the main entry using an environment variable. However, with Native AOT, separate app bundles are required for each test project since the main entry point can't be passed as an environment variable. We plan to implement it as a follow-up.

@MichalStrehovsky
Copy link
Member

MichalStrehovsky commented Aug 3, 2023

+1 to what Jan said - most of the disabled test look like something we should be running, we just have an infra problem. We should have an issue to track the infra problem and link it from all the disabling lines. Might want to put it on a separate line so that instead of this:

    <!-- Requires the framework to also be compiled with UseSystemResourceKeys -->
    <CLRTestTargetUnsupported Condition="'$(IlcMultiModule)' == 'true' or '$(TargetsAppleMobile)' == 'true'">true</CLRTestTargetUnsupported>

We have this:

    <!-- Requires the framework to also be compiled with UseSystemResourceKeys -->
    <CLRTestTargetUnsupported Condition="'$(IlcMultiModule)' == 'true'">true</CLRTestTargetUnsupported>

    <!-- Test infra issue on apple devices https://... -->
    <CLRTestTargetUnsupported Condition="'$(TargetsAppleMobile)' == 'true'">true</CLRTestTargetUnsupported>

@kotlarmilos
Copy link
Member Author

/azp run runtime-ioslike,runtime-ioslikesimulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kotlarmilos
Copy link
Member Author

The failures are known and shouldn't be related.

@kotlarmilos kotlarmilos merged commit d56723b into dotnet:main Aug 4, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NativeAOT] Enable System.Linq.Expressions tests on iOS-like platforms
5 participants